Strip endpoint hostname trailing slash#229
Merged
steffyP merged 2 commits intolocalstack:masterfrom Jan 23, 2024
Merged
Conversation
Not stripping the trailing slash leads to malformed URLs in the output, like so: https://7d7c2bf6.execute-api.localhost.localstack.cloud:4566//local/task
The earlier fix broke old Serverles endpoints
steffyP
approved these changes
Jan 23, 2024
Member
steffyP
left a comment
steffyP
left a comment
There was a problem hiding this comment.
Hi @kristallizer,
sorry for the long delay. I have tested your changes, and it's working 👍
Nice job 🚀
Member
|
Hi @kristallizer, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Not stripping the trailing slash leads to malformed URLs in the output:
Before: https://7d7c2bf6.execute-api.localhost.localstack.cloud:4566//local/task
After: https://7d7c2bf6.execute-api.localhost.localstack.cloud:4566/local/task
The right choice here is dependent on how you define the
pathinserverless.yml. Seeing how the official docs for API Gateway v2 add a/before the path, I propose that the trailing slash should be stripped here.